[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-05 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5208 Merged, and thanks for fixing this! 👍 Could you please close the PR? ---

[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-04 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5208 The same commit should be applied to master, right? ---

[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-04 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5208 @EronWright Yes, you're right. 👍 I'll merge ---

[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-03 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/5208 @aljoscha that might work but the independence is also nice. In this case, Fenzo is using Jackson 2.4.5 while Flink itself is using 2.7.9. How strongly do you feel about this? ---

[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-03 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5208 With this change we will have Jackson shaded/relocated twice in `flink-dist`: once under `org.apacha.flink.shaded.jackson2` and once under `org.apache.flink.mesos.shaded`. @zentol Wouldn't

[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-02 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/5208 @aljoscha please review ---

[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-02 Thread jaredstehler
Github user jaredstehler commented on the issue: https://github.com/apache/flink/pull/5208 looks good to me, thanks! ---