[GitHub] flink issue #5239: [FLINK-8360] Implement task-local state recovery

2018-01-09 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5239 Thanks for going through the general design @StephanEwen ! As we discussed, I agree with your first point. For the second point about RocksDB, this PR already contains an optimized way to

[GitHub] flink issue #5239: [FLINK-8360] Implement task-local state recovery

2018-01-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5239 I did a peer review and walk through the code. Overall, the design look good, +1 for that! Some comments: - I would argue to change the way that these recovery options are

[GitHub] flink issue #5239: [FLINK-8360] Implement task-local state recovery

2018-01-04 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5239 CC @aljoscha @pnowojski ---