[GitHub] flink issue #5439: [FLINK-8571] [DataStream] [Backport] Introduce utility fu...

2018-02-09 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5439 Thanks for the reviews! Will merge. ---

[GitHub] flink issue #5439: [FLINK-8571] [DataStream] [Backport] Introduce utility fu...

2018-02-09 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5439 LGTM once Travis is green. We should also remove the redundant mention of FLINK-8571 in `ReinterpretAsKeyedStreamITCase` while merging. ---

[GitHub] flink issue #5439: [FLINK-8571] [DataStream] [Backport] Introduce utility fu...

2018-02-09 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5439 Added the test. ---

[GitHub] flink issue #5439: [FLINK-8571] [DataStream] [Backport] Introduce utility fu...

2018-02-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5439 The changes look good! But as @tzulitai mentioned the missing Scala tests seem strange. ---

[GitHub] flink issue #5439: [FLINK-8571] [DataStream] [Backport] Introduce utility fu...

2018-02-09 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5439 CC @aljoscha @tzulitai ---