[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5481 Thanks @bowenli86 ! I will merge as soon as Travis gives green. ---

[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5481 @kl0u @aljoscha I added the scala example, and I believe the only build failure in Travis is irrelevant ---

[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5481 @kl0u I added the comments for `@deprecated` in the javadoc. Let me know if you can merge the two related PRs. Thanks ---

[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5481 Thanks for the review and suggestions. And your comment on `DataStream#process(KeyedProcessFunction)` makes sense, I've removed it. (btw, I feel https://github.com/apache/flink/pull/5500 i

[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5481 cc @pnowojski @aljoscha ---

[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5481 I think you can rename the existing one to `LegacyKeyedProcessOperator` or something like this and have a comment that describes the situation. ---

[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5481 @aljoscha @pnowojski Guys, quick question. I'm about to develop `KeyedProcessFunction` and its operator in a keyed stream. But I found there's already a `KeyedProcessOperator` which is for `Proces

[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5481 @aljoscha Great idea! I think that's the way to go! Thanks for bringing it up! ---

[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5481 @bowenli86 You can take a look at `KeyedBroadcastProcessFunction`. I think we could also add a `KeyedProcessFunction`, that has the key type in the signature. This would allow exposing the key in `o

[GitHub] flink issue #5481: [FLINK-8560] Access to the current key in ProcessFunction...

Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5481 cc @pnowojski ---