Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5582
LGTM ð Very nice work. I will merge it with some very minor touchups.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
Hi @StefanRRichter I updated the PR according to the previous discussions,
could you please have a look when you have time? The travis failed is
unrelated, it's a checkstyle error introduced by
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
@StefanRRichter Thanks for your nice review and preventing this PR to fall
into a sick way, I will change the code according to your comments and ping you
again when I finish this.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
@StefanRRichter Thanks for your nice review, addressed your comments, could
you please have a look again?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
Hi @StefanRRichter could you please have a look at this?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
Unfortunately, after confirming with RocksDB, the `deleteRange()` is still
an experimental feature, it may have impact on read performance currently(event
thought we could use the ReadOption to
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
Thanks, looking forward.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5582
Thanks for the contribution! We are currently busy with the 1.5 release. I
will have a closer look at this PR and your other pending JIRAs after the
release is out.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5582
@StefanRRichter Could you please have a look at this?
---
