[GitHub] flink issue #5650: [FLINK-8845][state] Introduce RocksDBWriteBatchWrapper to...

2018-05-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5650 @sihuazhou thanks for this nice contribution. LGTM 👍 Will merge. ---

[GitHub] flink issue #5650: [FLINK-8845][state] Introduce RocksDBWriteBatchWrapper to...

2018-05-21 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5650 A micro-benchmark for this: @StefanRRichter @StephanEwen ``` ---> With disableWAL is false <- Number of values added | time for Put |

[GitHub] flink issue #5650: [FLINK-8845][state] Introduce RocksDBWriteBatchWrapper to...

2018-03-14 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5650 @bowenli86 Thanks a lot for you reviews, I've addressed all your comments, I'm waiting the 1.5 to be released, after that maybe @StefanRRichter could also have a look at this. ---