[GitHub] flink issue #5761: [FLINK-8989] [e2eTests] Elasticsearch1&2&5 end to end tes...

2018-05-22 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5761 Thanks @tzulitai for review this patch! ~ 👍 ---

[GitHub] flink issue #5761: [FLINK-8989] [e2eTests] Elasticsearch1&2&5 end to end tes...

2018-05-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5761 +1, LGTM, merging ... ---

[GitHub] flink issue #5761: [FLINK-8989] [e2eTests] Elasticsearch1&2&5 end to end tes...

2018-05-21 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5761 Hi, @tzulitai Could you take another look on this PR ? It's the time for having another review. Update the code according to your suggestions and I ran the test on my local machine and below

[GitHub] flink issue #5761: [FLINK-8989] [e2eTests] Elasticsearch1&2&5 end to end tes...

2018-05-09 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5761 Hi, @tzulitai What is the state of this PR ? thanks. This PR is ready to have another review. ---

[GitHub] flink issue #5761: [FLINK-8989] [e2eTests] Elasticsearch1&2&5 end to end tes...

2018-03-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5761 I think I found how to solve this issue. I will fix it as soon as possible. ---

[GitHub] flink issue #5761: [FLINK-8989] [e2eTests] Elasticsearch1&2&5 end to end tes...

2018-03-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5761 I think I found how to solve this issue. I will fix it as soon as possible. ---

[GitHub] flink issue #5761: [FLINK-8989] [e2eTests] Elasticsearch1&2&5 end to end tes...

2018-03-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5761 I think I found how to solve this issue. I will fix it as soon as possible. ---

[GitHub] flink issue #5761: [FLINK-8989] [e2eTests] Elasticsearch1&2&5 end to end tes...

2018-03-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5761 I found an issue, I tried find it out but it seems useless. For elasticsearch5sink, I can run directly with the following command with flink cluster setup and elasticsearch5 cluster set