[GitHub] flink issue #5803: [FLINK-9124] [kinesis] Allow customization of KinesisProx...

2018-04-18 Thread tzulitai
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/5803
  
As discussed on the mailing list 
(http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Kinesis-getRecords-read-timeout-and-retry-td21844.html),
 lets merge the PR as it is for now.

Some final remarks:

- I see that we already have a JIRA to improve generic configuration 
support: https://issues.apache.org/jira/browse/FLINK-9188.

- For the fullJitterBackoff and retry handling, I wonder if a user-provided 
retry handler would be more appropriate (as a future improvement). For example, 
our Elasticsearch connector has something similar.

Merging this for 1.6.0 and 1.5.0 ..


---


[GitHub] flink issue #5803: [FLINK-9124] [kinesis] Allow customization of KinesisProx...

2018-04-10 Thread tweise
Github user tweise commented on the issue:

https://github.com/apache/flink/pull/5803
  
@aljoscha @tzulitai can you take a look?


---