[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5834 LGTM ð Will rebase and merge once my Travis is green. ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 @zentol thanks for your clarification. Actually, when I start join Flink community, most of the PRs were reviewed by you and till. Both of you gave me a lot of suggestion and technical opinion. What's more, you are the most frequently in the issue mailing list. So I always ping you and till, I don't know this behavior brought you burden. Maybe there is a bad phenomenon: more times been saw, more times been pinged. Actually, from my (a contributor like others) view point, I don't know the committer's review plan. And the PRs take more time would take more cost (especially, like this PR in reviewing status). The contributors and committers both would look back into it's context. I ping you sometimes because I think you are reviewing other PRs, at that point, maybe this behavior would not disturb your coding. And sometimes, I may not need you to review immediately. You can give a explication or time point about reviewing or ping another committer (who work together with you) to review. Generally, a effective feedback. Now, I know your standpoint and trouble. Sorry about my behavior. You and others are good. cc @StephanEwen ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5834 Generally I would refrain from pinging specific committers. This can be counter-productive as it discourages other committers, or even contributors, from taking a look. Similarly, pinging a committer in every PR because you saw them reviewing other PRs at the time (as has happened to me last week) isn't that helpful either. It just pushes even more work/pressure on the few committers that actually do reviews. (Note that frequent pinging inherently puts more work on me as i actually monitor all PR updates!) At last, please keep in mind that not all PRs have the same priority, especially when working towards the next release. Documentation changes (#5773) _can_ be merged after a release (since the docs aren't part of the release!), code-cleanups (#5777, #5799) and minor fixes (#5798) are usually non-critical and always pose the risk of introducing new bugs which is the last thing we want shortly before a release. ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5834 Committers usually have a lot of different responsibilities (releases, testing, helping users on mailing lists, working on roadmap features, etc.). All that takes a lot of time. Reviewing PRs is one important part, and we try to do this well, but with so many users now, it is not always perfect. One big problem is that very few committers actually take the time to look at external contributions. I might help to not always ping the same people (for example @zentol , @tillrohrmann , me, etc.) but some other committers as well. Here is a list of other committers, it is not quite complete, some newer ones are not yet listed: http://flink.apache.org/community.html#people Hope that helps you understand... ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 hi @StephanEwen why the committers do not review those old PRs? I have serval PRs which take so long time. ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 cc @zentol ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 @zentol this PR also reviewed by you, and takes a long time, can you review this? thanks~ ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 cc @zentol ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 @zentol this PR also reviewed by you, and takes a long time, can you review this? thanks~ ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 cc @zentol refactored based on your suggestion, please review it again ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 cc @zentol @tzulitai ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 cc @zentol ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 cc @tillrohrmann : If you have time, please review this PR, thanks. ---
[GitHub] flink issue #5834: [FLINK-9153] TaskManagerRunner should support rpc port ra...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5834 cc @tillrohrmann for mode : `new` (flip-6) the `TaskManagerRunner` could not specify a port range, I suggest we could merge this PR as a hotfix issue and add it into 1.5 release. ---
