Github user XiaoZYang commented on the issue:
https://github.com/apache/flink/pull/5845
@zentol got it! So what you mean is that @sijie and I will keep updating
commits until this work is done and you guys will merge this PR to a new
branch. Later PR will be against the new branch.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5845
it is not possible to create a PR against a non-existing branch. We will
either have to create a pulsar-connector branch up front, or open the first PR
against master and merge it into a new branch.
Github user XiaoZYang commented on the issue:
https://github.com/apache/flink/pull/5845
@hsaputra There is no error but the issue is
1. when I create a PR to the flink repo from my fork repo I need to choose
a branch to which the commits are merged to
2. I'm expected to
Github user hsaputra commented on the issue:
https://github.com/apache/flink/pull/5845
@XiaoZYang You can close this PR and create new branch to submit new PR
since you are the creator os this one.
Did you see any error or something preventing you to close this one?
---
Github user XiaoZYang commented on the issue:
https://github.com/apache/flink/pull/5845
I prefer to open a new PR and a new branch. But I am not authorized to do
that.
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5845
Sorry for delays on my reply here. I'll take a look at this week, over the
next days.
If there is going to be a new PR, please also let me know. Thanks!
---
Github user XiaoZYang commented on the issue:
https://github.com/apache/flink/pull/5845
@tzulitai @surryr @pluppens @sijie
This PR is going to be closed and I will open another PR to brunch
pulsar-connector to this issue.
---
Github user sijie commented on the issue:
https://github.com/apache/flink/pull/5845
@tzulitai what is your opinion about @XiaoZYang 's comment?
---
Github user XiaoZYang commented on the issue:
https://github.com/apache/flink/pull/5845
Hi @sijie @tzulitai, since there will be serial of commits about *pulsar
connector*, what about close this pr and reopen a new PR which is going to
merge to a new branch named "pulsar-connector".
Github user XiaoZYang commented on the issue:
https://github.com/apache/flink/pull/5845
ping @sijie
---
Github user XiaoZYang commented on the issue:
https://github.com/apache/flink/pull/5845
@sijie would you mind help reviewing this commit?
---
Github user sijie commented on the issue:
https://github.com/apache/flink/pull/5845
@pluppens thank you for your comments. I was busy with pulsar 2.0 release.
I will try to pick this up again soon :)
---
Github user sijie commented on the issue:
https://github.com/apache/flink/pull/5845
@tzulitai thank you very much for you help. just sent an email to
dev@flink. look forward to feedback from flink community and collaboration
between flink and pulsar communities.
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5845
Welcome to the community!
@sijie I think for this a general discussion email thread will be enough.
---
Github user sijie commented on the issue:
https://github.com/apache/flink/pull/5845
@tzulitai thank you for your comments. Glad to hear your opinions about
pulsar connectors. I was the original person who initiated the idea of flink
pulsar connectors with @XiaoZYang, I am also from
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5845
Thanks for this contribution @XiaoZYang! Pulsar seems like an interesting
project.
I think before we proceed with this, we need to make it clear
(community-wise) that if we do accept this
16 matches
Mail list logo
