Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5964
That the example doesn't work isn't related to this PR so I'll merge it as
is.
But I'll take a look what the problem is, and either fix it or open a JIRA.
---
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
Ok great!, I'd like to mention that `CassandraPojoSinkExample.main()`
doesn't seem to work:
`source.getType()` is computed as a `GenericType` in the
`env.fromCollection(messages);`.
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
Okay, I've pushed the changes.
---
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
I pushed the changes about renaming the method to setDefaultKeyspace() and
the message in the exception. The field is still 'keyspace', we dont rename it
to 'defaultKeyspace' right ?
---
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
Hi, is there something else we can do for this PR/issue ?
---
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
I pushed the changes and refactored to use `sanityCheck` method to check
the `keyspace` depending the builder in use. (like it is already done with
`query`)
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5964
h so that where it is used...
---
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
> The keyspace field in the sink isn't used anywhere
It is used in CassandraPojoSinkBuilder.createSink(), the keyspace is an
argument of `new CassandraPojoSink<>(...);`
```
Github user ctamisier commented on the issue:
https://github.com/apache/flink/pull/5964
@zentol, @StephanEwen, @Bekreth
> We would have to pass the keyspace via the constructor as the
Configuration approach doesn't work for streaming.
I'm not sure to understand, the new
