[GitHub] flink issue #5977: [FLINK-9295][kafka] Fix transactional.id collisions for F...

2018-05-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5977 Thanks for the update @pnowojski. Changes LGTM, +1. Merging this .. ---

[GitHub] flink issue #5977: [FLINK-9295][kafka] Fix transactional.id collisions for F...

2018-05-17 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/5977 I have removed `getOperatorUniqueID()` from `RuntimeContext` and our `FlinkKafkaProducer011` is now casting `RuntimeContext` to `StreamingRuntimeContext`. ---

[GitHub] flink issue #5977: [FLINK-9295][kafka] Fix transactional.id collisions for F...

2018-05-15 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5977 Overall LGTM 👍 ---