[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...
Github user medcv commented on the issue: https://github.com/apache/flink/pull/5996 @StephanEwen I would appreciate it if you do the review after my changes! ---
[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...
Github user medcv commented on the issue: https://github.com/apache/flink/pull/5996 @StephanEwen PR is updated as requested! I would appreciate if you review. ---
[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen I updated the code and used `ExecutionContext.global` which
makes use of threadpool.
I tested it and results showed that the code sent off multiple requests
concurrently (parallelism = 1).
Bellow result shows that waiting time was overlaying with sending other
requests and receiving responses
Output format: `(Quote Number, {Quote API response})` which `Quote Number`
was sequential input.
https://user-images.githubusercontent.com/9163132/40592122-6ea8ef5a-61e9-11e8-99d5-2deeffa3d9be.png;>
Bellow result is when I called the external api within streaming API which
shows the call is blocked until request got resolved
https://user-images.githubusercontent.com/9163132/40592123-70b03d62-61e9-11e8-9068-eef2a102f19b.png;>
---
[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...
Github user medcv commented on the issue: https://github.com/apache/flink/pull/5996 @StephanEwen Thanks for review. make sense, I will update the client code to use Threadpool and will run more tests. ---
[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5996 Async I/O works best with asynchronous clients. For synchronous client, you need a threadpool or something else to concurrently fire off requests. ---
[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5996 I had a quick look at the code example, and it looks like it might not actually do asynchronous I/O. It dispatches a synchronous HTTP request on a direct executor (`onComplete`s in a direct executor as well), which should result us purely synchronous operations. Have you verified that this does in fact send off multiple requests concurrently (beyond the parallelism)? ---
[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...
Github user medcv commented on the issue: https://github.com/apache/flink/pull/5996 @zentol I would appreciate if you review this. We use this type of example for enriching our Steam data via API call which is very common use-case and I think it would be useful for other people to have an example for it. ---
[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...
Github user medcv commented on the issue: https://github.com/apache/flink/pull/5996 @tzulitai I would appreciate if you review this. ---
[GitHub] flink issue #5996: [FLINK-9343] [Example] Add Async Example with External Re...
Github user medcv commented on the issue: https://github.com/apache/flink/pull/5996 @StephanEwen please review ---
