[GitHub] flink issue #6090: [FLINK-8863] [SQL] Add user-defined function support in S...

2018-07-06 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6090 Thank you very much @xccui! I will have a final pass over the chances and merge this. I think we this PR we cover the most important cases. I will open follow-up issues for docs etc. We can add

[GitHub] flink issue #6090: [FLINK-8863] [SQL] Add user-defined function support in S...

2018-07-06 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/6090 Hi @twalthr, I've made some changes to the PR. 1. Add a normalize method in `ClassTypeValidator` which converts the config like `constructor.0 = abc` to `constructor.0.type = STRING

[GitHub] flink issue #6090: [FLINK-8863] [SQL] Add user-defined function support in S...

2018-07-05 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6090 @xccui perfect. thank you very much! ---

[GitHub] flink issue #6090: [FLINK-8863] [SQL] Add user-defined function support in S...

2018-07-05 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/6090 Hi @twalthr, please give me one more day. I will commit the changes tomorrow. 😄 ---

[GitHub] flink issue #6090: [FLINK-8863] [SQL] Add user-defined function support in S...

2018-07-05 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6090 Hi @xccui, sorry for being pushy but when do you think you can update this PR? The feature freeze is in approx. 1 week and I need to coordinate my work/reviewing efforts. Let me know if you want me

[GitHub] flink issue #6090: [FLINK-8863] [SQL] Add user-defined function support in S...

2018-06-28 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6090 @xccui no problem. great to hear that you graduated :) The feature freeze is in approximately 3 weeks, we should be done by then. Let me know if you need support. ---

[GitHub] flink issue #6090: [FLINK-8863] [SQL] Add user-defined function support in S...

2018-06-27 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/6090 Hi @twalthr, sorry for the delay. I've been quite busy with my graduation these weeks. Everything's finished now and I'll put these tasks back on track. ---