[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6247 @nekrassov, :+1: , you can fork `flink` project, then create a PR to fix. ---
[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...
Github user nekrassov commented on the issue: https://github.com/apache/flink/pull/6247 https://issues.apache.org/jira/browse/FLINK-9784 created ---
[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6247 @nekrassov, @zentol, I'll revert it, just fix static references. I didn't pay attention to the problem of concurrency at first. ---
[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6247 @nekrassov, yan can open a separate JIRA. here's address [FLINK-JIRA](https://issues.apache.org/jira/projects/FLINK) ---
[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...
Github user nekrassov commented on the issue: https://github.com/apache/flink/pull/6247 lamber-ken, please let me know if you will open a separate JIRA and PR to make `random, executorService` non-static, remove `synchronized`, and remove `counter`. Or I can do that. ---
[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6247 for the AsyncIOExample, please revert the change to the `counter` field, and open a separate JIRA and PR. This issue is specifically about fixing static references. ---
[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...
Github user nekrassov commented on the issue: https://github.com/apache/flink/pull/6247 there is a "Show outdated" button to see comments on the reverted commit. I sent email to dev list, because I'm still not clear what was the original intent of the code, and how open() behaves. ---
[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6247 @nekrassov, you are strict and right. when I revert, the communication between us was removed by github. ---
[GitHub] flink issue #6247: [FLINK-9730] [code refactor] fix access static via class ...
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6247 @zentol, @tillrohrmann hi, cc. I fixed some cases access static via class reference ---
