[GitHub] flink issue #6250: [FLINK-8864][Table API & SQL] added command history for S...

2018-07-06 Thread twalthr 
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/6250
  
Thanks @snuyanzin. Currently, we are busy with the feature freeze next 
week. I will take a look as soon as possible.

One feedback that I can give now: We should make the history file 
configurable somewhere. It would be useful to create a config files 
`conf/sql-client-cli.conf` (and in the future `conf/sql-client-gateway.conf`) 
this can also be used to configure other properties in the future.


---

[GitHub] flink issue #6250: [FLINK-8864][Table API & SQL] added command history for S...

2018-07-06 Thread snuyanzin 
Github user snuyanzin commented on the issue:

https://github.com/apache/flink/pull/6250
  
cc @twalthr  as you are the issue reporter could you please have a look 
here?


---