[GitHub] flink issue #6263: [FLINK-9743][Client] Use correct zip/jar path separator

2018-07-10 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6263 yes, `TemporaryFolders` should always be final, regardless of what existing code does. ---

[GitHub] flink issue #6263: [FLINK-9743][Client] Use correct zip/jar path separator

2018-07-10 Thread snuyanzin
Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/6263 ok, thank you for review about `public TemporaryFolder temporaryFolder = new TemporaryFolder();` could be final - agree. However while searching for usages I realized that in most cases it

[GitHub] flink issue #6263: [FLINK-9743][Client] Use correct zip/jar path separator

2018-07-10 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6263 If it work I'll fix the issue I found and merge it afterwards. ---