[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6266 @zentol can you review this PR? so that I can start the part 2 of the task as soon as possible. thanks. ---
[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6266 hi @tillrohrmann I have split the original issue into two issues, this PR for the first backend issue, the second issue will depend on this PR, please review~ ---
[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/6266 I would be ok with splitting the work between the backend and frontend work. @zentol raised an important point which is where to place the content. Wha about the following proposal?   Where the red arrows are we could insert new columns for the description. But I'm not a terribly good web designer... ---
[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6266 @hequn8128 thanks for your suggestion. Yes, cutting off the description is a choice. But currently, for the web UI, if the description does not show in a new line, there is only little zone can be used. In this situation, if we cut off the description would confuse users. ---
[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6266 Hi @yanghua , I think if the description is too long, we can simply cut off the description. It is safe and easy. ---
[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6266 hi @tillrohrmann what's your idea about the way of showing the description of the job, or split the issue into backend API and frontend presentation? ---
[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6266 @zentol yes, if the description is very long, that would be not suitable to display, maybe other choose : * show a tip with mouseover event? * pop a window to display? what about split this issue into two task? * provide a `setDescription` API * display it on the web page ---
[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6266 That's really something that should've been cleared up in the JIRA before any line of code was written. On the spot i can't think of a good place to put it. You would want this description to show up in the job overview, but longer descriptions won't fit in there I believe. ---
[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6266 @zentol yes, this PR did not contain the code about displaying the description of the job on the web page, I want to hear the opinion fro you and @tillrohrmann , how to show the description? display behind the job name in job detail page? ---
[GitHub] flink issue #6266: [FLINK-9682] Add setDescription to execution environment ...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6266 Travis failed, please investigate. ---
