Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6272
Thanks for the review, merging...
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6272
rebased to solve the merge conflict (auto-solved by git though)
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6272
actually, I forgot to adapt the unit test which relied on the previous
order of the calls and assumed that the buffer got recycled. With the changes
from the fixup, the buffer is not recycled by the
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/6272
LGTM!
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/6272
thanks for the review - I changed the code as requested
---
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/6272
Thanks for fixing this potential bug.
It makes sense to handle exception during `notifyBufferAvailable` on
listener side. Just some thoughts on my side above. :)
---
