[GitHub] flink issue #6334: [FLINK-5232] Add a Thread default uncaught exception hand...

2018-07-18 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/6334
  
Thanks for opening this PR @yanghua. The community is currently preparing 
the Flink 1.6 release. Due to this, it might take a bit longer until someone 
can review this PR. Please bear with us until then.


---


[GitHub] flink issue #6334: [FLINK-5232] Add a Thread default uncaught exception hand...

2018-07-18 Thread yanghua
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/6334
  
@tillrohrmann and @zentol  opinion?


---


[GitHub] flink issue #6334: [FLINK-5232] Add a Thread default uncaught exception hand...

2018-07-14 Thread yanghua
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/6334
  
hi @tillrohrmann I tried to fix this issue based on your suggestion in the 
jira. But there seems a little question, I want to consult you.

The question is about the ActorSystem, you suggested add the uncaught 
exception handler for the `ActorSystem`. To do this, we should extend the 
`ActorSystemImpl` (the default implementation). This class's constructor has 
[many 
parameters](https://github.com/akka/akka/blob/master/akka-actor/src/main/scala/akka/actor/ActorSystem.scala#L651).
 I am not very familiar with it. So I tried fill the ["default" 
params](https://github.com/yanghua/flink/blob/27dec5d60d2e799aeea66013b3da904cec137408/flink-runtime/src/main/scala/org/apache/flink/runtime/akka/RobustActorSystem.scala#L33).
 I ran the test case, they always failed because of the fifth parameter. 

So the question is the `ActorSystemImpl` is marked as `InternalApi `, it 
may be changed in the future, shall we extend a actor system based with it? If 
yes, what's the correct value for these parameter?

I saw some similar customized case, such as 
[this](https://gist.github.com/aarondav/ca1f0cdcd50727f89c0d#file-exceptioncatchingactorsystemimpl-scala-L14)
 and 
[this](https://gist.github.com/Kayrnt/9082178#file-rebootactorsystem-scala-L28).
 However, it seems their version are both lower. 

So hope for your idea and suggestion.


---