[GitHub] flink issue #6370: [FLINK-9894] [runtime] Potential Data Race

2018-07-19 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6370 @zentol ok ... close as suggested, would be resolved in #6353 ---

[GitHub] flink issue #6370: [FLINK-9894] [runtime] Potential Data Race

2018-07-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6370 If another PR introduces race conditions, then these race conditions should be resolved in that very PR. ---

[GitHub] flink issue #6370: [FLINK-9894] [runtime] Potential Data Race

2018-07-19 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6370 but the original `ensureConstraints` is wired. For example it calls `ensureCapacity` twice and the only code path is from `ExecutionJobVertex` construct `ExecutionVertex` which calls

[GitHub] flink issue #6370: [FLINK-9894] [runtime] Potential Data Race

2018-07-19 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6370 @yanghua AFAIK, yes. ---

[GitHub] flink issue #6370: [FLINK-9894] [runtime] Potential Data Race

2018-07-19 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6370 @tison1 I think PR #6353 and #6370 has causal relationship, the current codebase may not trigger this race condition, right? ---

[GitHub] flink issue #6370: [FLINK-9894] [runtime] Potential Data Race

2018-07-19 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6370 by analyses the use path of this method, we gain little on `ensureCapacity`, in fact, test fails on #6353 is caused by too many `ensureCapacity` and then `Array.copyOf` race each other. ---