[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-72678344 I modified the merged version to exclude it from rat. I also tried subsequent builds, it worked. See here: https://github.com/apache/flink/commit/0c726f833892a03a12cc92d35e7d249369eb0dc9#diff-600376dffeb79835ede4a0b285078036R1046 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/333 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71610034 In addition to that, we should probably investigate why the clean phase is not removing the directory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71633168 So either we can somehow change the execution order of the clean goal or we fix this in the junction plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71470142 Yes, I thought it would handle it as well, but I just ran it and it didn't work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/333#discussion_r23528552
--- Diff: flink-dist/pom.xml ---
@@ -436,6 +436,37 @@ under the License.
/gitDescribe
/configuration
/plugin
+
+ !-- create a symbolic link to the build target in the
root directory --
+ plugin
+ groupIdcom.pyx4j/groupId
+ artifactIdmaven-junction-plugin/artifactId
+ version1.0.3/version
+ executions
+ execution
+ phasepackage/phase
+ goals
+ goallink/goal
+ /goals
+ /execution
+ execution
+ idunlink/id
+ phaseclean/phase
+ goals
+ goalunlink/goal
+ /goals
+ /execution
+ /executions
+ configuration
+ links
+ link
+
dst${basedir}/../build-target/dst
--- End diff --
I couldn't find a document stating that $basedir is deprecated, but I think
you are right in the sense that the project prefix is used for everything
related to the POM of the project (I think in previous versions the (now
deprecated) prefix was `pom` and both the `version` and `basedir` properties
are built-ins).
We use $basedir in other places as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/333#discussion_r23527422
--- Diff: flink-dist/pom.xml ---
@@ -436,6 +436,37 @@ under the License.
/gitDescribe
/configuration
/plugin
+
+ !-- create a symbolic link to the build target in the
root directory --
+ plugin
+ groupIdcom.pyx4j/groupId
+ artifactIdmaven-junction-plugin/artifactId
+ version1.0.3/version
+ executions
+ execution
+ phasepackage/phase
+ goals
+ goallink/goal
+ /goals
+ /execution
+ execution
+ idunlink/id
+ phaseclean/phase
+ goals
+ goalunlink/goal
+ /goals
+ /execution
+ /executions
+ configuration
+ links
+ link
+
dst${basedir}/../build-target/dst
--- End diff --
Isn't based deprecated? In the next line you use project.basedir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user uce commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71454018 Very nice. +1 Will merge this later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71464164 -1 I think we need to add the `build-target` directory into the list of ignored directories for apache rat. Rat will fail subsequent builds ``` 1 Unknown Licenses *** Unapproved licenses: build-target/conf/slaves *** ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71469736 Oh, actually, that should work because the configuration explicitly binds the plugin to the clean phase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71598417 Okay, let's add an exclude for the linked target directory and update `basedir` to `project.basedir`. Will that do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71366786 This looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
