[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70416371 This would do it for now. However, the use of static variables to communicate between components is an antipattern and one that has caused problems before. I would

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70424146 The registration at Kryo seems to be a bit incomplete. Adding a default serializer does not to type/tag registration, which is very much desirable. Also, it registers

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70424921 Maybe we should offer users both options: register and default serializer. In some cases, you don't know the exact types and you want to go for a default serializer.

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-15 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70065763 I added register methods at the ExecutionEnvironment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-69896090 The second option (env) is probably better because people will see the method when their IDE suggests method names. --- If your project is set up for it, you can reply