Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/331
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-74088065
@rmetzger Thanks but I think it should be "This closes #331" :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-74072268
Remember to include "This closes #311" ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-74072237
Good work. Thank you.
I think its time for your first push to master ;)
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-74068524
Looks like a good improvement to me.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-74049747
Any further comments on the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-71818646
Cool, thank you. I'll try it out as soon as I find time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-71649409
Thanks for your feedback, @rmetzger . The error message is at the bottom
because that way it is most easily identifiable by the user (no scrolling
necessary). Before, we print
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-71467375
I think it would be better not to print the help if the user specified
something incorrectly. Maybe just the error message and a note that -h prints
the help?
I'
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-71446044
@rmetzger @StephanEwen I squashed the commits, merged the recent changes in
the CliFrontend on the master, and addressed
[FLINK-1424](https://issues.apache.org/jira/browse/FLI
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-71376859
@mxm: Since you have some experience with the CliFrontend now, would you
mind looking into https://issues.apache.org/jira/browse/FLINK-1424 as well?
---
If your project
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-71335704
Looks good to me.
+1 to merge (with commit squashing)...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/331#issuecomment-71212582
Testing JIRA integration FLINK-1436
Lets see
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/331#discussion_r23456811
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -413,29 +413,33 @@ protected int info(String[] args) {
Packag
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/331#discussion_r23456818
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -945,13 +948,10 @@ private int handleError(Throwable t) {
private voi
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/331#discussion_r23456787
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -960,14 +960,15 @@ public int parseParameters(String[] args) {
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/331#discussion_r23455860
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -413,29 +413,33 @@ protected int info(String[] args) {
P
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/331#discussion_r23455785
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -960,14 +960,15 @@ public int parseParameters(String[] args) {
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/331#discussion_r23455746
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -945,13 +948,10 @@ private int handleError(Throwable t) {
privat
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/331
[Flink-1436] refactor CLiFrontend to provide more identifiable and
meaningful error messages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/fl
20 matches
Mail list logo
