[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-02-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/353#issuecomment-73478102 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-02-09 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/353#issuecomment-73501310 Manually merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-02-05 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/353#issuecomment-73042896 Looks good. For efficiency, we could change the factory such that it returns the original in the first request, and a duplicate after that. Good change

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-02-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/353#issuecomment-73077279 Do you think that with the additional checking logic this would really make up for one superfluous duplication? --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-02-05 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/353#issuecomment-73078373 Yes. Some serializers are heavyweight and often, the factories produce only one serializer through their lifetime. It is a nice improvement, bot a crucial one,

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-02-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/353#issuecomment-73079161 Ok, then I'll add this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-01-30 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/353 [FLINK-1463] Fix stateful/stateless Serializers and Comparators Before, Serializers would announce whether they are stateful or not and rely on RuntimeStatefulSerializerFactory to do the