Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-88794279
I'm merging this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-88453493
If there are no objections, I'm going to merge the PR in the next 24 hours.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27564491
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -103,6 +110,9 @@ public void start() throws Exception {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27564493
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -70,6 +72,11 @@ public LocalExecutor() {
}
}
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27566199
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -103,6 +110,9 @@ public void start() throws Exception {
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27564611
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/LocalEnvironment.java ---
@@ -32,6 +33,7 @@
* machine.
*/
public class
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27566259
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -1058,6 +1059,20 @@ public static LocalEnvironment
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-88462555
Looks good.
It is possible to add a more Unit-Test style test, rather than an
Integration test case (starting a full mini cluster) ?
---
If your project is
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27569381
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -1058,6 +1059,20 @@ public static LocalEnvironment
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-88473959
Looks good.
- Can you add missing `@Override` tags to `executePlan` and
`getOptimizerPlanAsJSON` while editing the file?
- If you only want to ensure that the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-86979441
I've updated the PR. It is now ready for review again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-75542199
@tillrohrmann: Thank you for the good feedback!
I'll continue working on this once https://github.com/apache/flink/pull/410
is merged to master.
---
If your project
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r25152294
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/ExecutionEnvironmentITCase.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/427
[FLINK-1589] Add option to pass configuration to LocalExecutor
Please review the changes.
I'll add a testcase and update the documentation later today.
You can merge this pull request into
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-75244751
I've added documentation and tests to the change.
Lets see if travis gives us a green light.
---
If your project is set up for it, you can reply to this email and
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r25080967
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/ExecutionEnvironmentITCase.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-75271706
I think we should rework the test case to check that the configuration is
properly passed to the system. Right now the exception is thrown in
18 matches
Mail list logo
