[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/451#issuecomment-77194681 Allright. I was able to start a YARN session from the frontend. Also the `-h` is working now. --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-04 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/451#issuecomment-77206172 Manually merged in 5385e48d94a2df81c8fd6102a889cf42dd93fe2f --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-04 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/451#issuecomment-77132462 Except for the YARN test cases which fail, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/451#issuecomment-77131171 The two last build profiles are probably failing because the tests are checking on the output of the CLI frontend. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-04 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/451#discussion_r25763642 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -601,452 +482,295 @@ public int compare(ExecutionGraph o1,

[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-04 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/451#discussion_r25763670 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -601,452 +482,295 @@ public int compare(ExecutionGraph o1,

[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-04 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/451#discussion_r25765068 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/messages/JobManagerMessages.scala --- @@ -19,11 +19,14 @@ package

[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/451#issuecomment-77134702 The `-h` command is not working for the actions (tested with info and run) ``` [root@sandbox flink-yarn-0.9-SNAPSHOT]# ./bin/flink info -h 10:28:01,440

[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/451#issuecomment-77135314 The YARN application master doesn't start anymore with the following exception: ``` 10:31:01,526 ERROR org.apache.flink.yarn.ApplicationMaster$

[GitHub] flink pull request: [FLINK-1616] [client] Overhaul of the client.

2015-03-03 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/451 [FLINK-1616] [client] Overhaul of the client. - Fix bugs with non-serializable messages - Separate parser and action logic - Clean up tests - Vastly improve logging in CLI client