Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/525#issuecomment-86400852
I updated the PR as discussed:
- GlobalProperties are filtered with the user-specified semantic properties.
- LocalProperties for are filtered with forward field
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/525#issuecomment-85499509
Yes, I agree. The fix is more conservative than necessary.
I think we can safely relax it if we make the rule for forwarded fields on
group-wise operators as follows:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/525#issuecomment-85422608
I think this is good to fix this.
I was wondering now whether we can actually solve this a bit more
global/local property specific. Cancelling out the
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/525#issuecomment-85531186
Do you think this rule is easy enough for users?
It would make the handling consistent for all group-wise operators.
---
If your project is set up for it, you can
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/525#issuecomment-85528267
Good catch, that is a critical distinction (one output record forwarded
from same input record). Mostl relevant to MapPartition, though.
---
If your project is set
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/525
[FLINK-1656] Filter ForwardedField properties for group-at-a-time operators
in Optimizer
Restricts forward field information for group-wise operators.
- For `GroupReduce`, `GroupCombine`,
