Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/539#issuecomment-88414948
FYI: Travis failed only for the last profile because the tests didn't start
for some reason. Travis passed for my own repository, though.
---
If your project is set
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/539#issuecomment-88123548
I rebased the code on the current master and unified some of the tests.
When Travis confirms that everything works and if there are no objections, I'll
merge the PR.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/539#issuecomment-87060638
I combined some of the sanity checks of the matrix/vector accessors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/539#discussion_r27321365
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/SparseMatrix.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/539#discussion_r27321156
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/SparseMatrix.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/539#issuecomment-86996068
Looks good to merge.
There are some performance improvements possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/539#discussion_r27308257
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/SparseMatrix.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Soft
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/539#discussion_r27307815
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -67,7 +63,25 @@ case class DenseVector(val values: Array[Do
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/539#discussion_r27261446
--- Diff: flink-staging/flink-ml/pom.xml ---
@@ -46,9 +46,9 @@
- com.github.fommil.netlib
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/539#discussion_r27256008
--- Diff: flink-staging/flink-ml/pom.xml ---
@@ -46,9 +46,9 @@
- com.github.fommil.netlib
---
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/539
[FLINK-1718] Adds sparse matrix and sparse vector
Adds a sparse matrix abstraction using CSC data representation. Adds a
sparse vector abstraction using CSC data representation.
Adds co
12 matches
Mail list logo
