Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/589#issuecomment-92834090
I would like to merge this PR rather soon because I need some of the
changes from this PR for adding another KafkaITCase.
Is it okay to postpone the refactor to
Github user gaborhermann commented on the pull request:
https://github.com/apache/flink/pull/589#issuecomment-92846151
Yes, of course, we can postpone the refactor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/589
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/589#issuecomment-92902901
I'm merging the PR now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/589#discussion_r28257271
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java
---
@@ -524,13
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/589#discussion_r28227428
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTopicUtilsTest.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/589#discussion_r28227273
--- Diff:
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/589#discussion_r28227590
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java
---
@@ -524,13
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/589#discussion_r28227565
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/KafkaSink.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/589#discussion_r28227177
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/simple/KafkaTopicUtils.java
---
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/589#discussion_r28227162
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/simple/KafkaTopicUtils.java
---
Github user gaborhermann commented on the pull request:
https://github.com/apache/flink/pull/589#issuecomment-92413840
Thanks for the comments, I made the proposed changes (except Marton's).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user gaborhermann commented on a diff in the pull request:
https://github.com/apache/flink/pull/589#discussion_r28251514
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java
---
@@
13 matches
Mail list logo
