Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/553
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-100221773
Great. Once this is green, I'll push it to master:
https://travis-ci.org/rmetzger/flink/builds/61757934
---
If your project is set up for it, you can reply to this emai
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-100220928
LGTM :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user bhatsachin commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-99804027
I have made the change. Thanks a lot Robert and Till. I too am looking
forward to contribute more :)
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-99800432
Okay, I'll wait until this last issue is fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-99799547
Wait, I would actually like to move the bean retrieval into the map
function of the method option. Otherwise on Java 6 you always retrieve this
bean without ever usin
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-99796254
Okay, I'm satisfied with my local tests. I'll rebase your changes to the
current master, wait until travis gives green light and then merge the changes!
Thank you
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-99787426
Okay, you are right. Then we can keep it this way.
Let me try out your changes one more time, but then I think we are good to
merge.
---
If your project is set
Github user bhatsachin commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-99786510
Hey Robert, please correct me if I am wrong. According to this doc,
https://docs.oracle.com/javase/7/docs/jre/api/management/extension/com/sun/management/OperatingSy
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-99759058
That would be more javaesque than scalaesque. I would rather move the
osMXBean retrieval into the map function of the `fetchCPULoad` option. That
also solves the prob
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-99753925
The code looks much better now. The only thing that makes me still unhappy
is the following method
```diff
+ override def getValue: Double = {
+t
Github user bhatsachin commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29786547
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
ov
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29745454
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29744552
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,49 @@ object TaskManager {
Github user bhatsachin commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29682706
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
ov
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-99063892
Thanks for your work @bhatsachin. I had some remarks concerning the Scala
style.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29662847
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29662751
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29662694
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29662675
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29662593
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
Github user bhatsachin commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29650540
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
ov
Github user bhatsachin commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29650229
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
ov
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29648339
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
over
Github user bhatsachin commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29636725
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -129,6 +130,41 @@ class TaskManager(val connectionInfo
Github user bhatsachin commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29636610
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -129,6 +130,41 @@ class TaskManager(val connectionInfo
Github user bhatsachin commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29636451
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -129,6 +130,41 @@ class TaskManager(val connectionInfo
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-98640261
I tried our your changes and looked at the change.
- The pull request includes commits which are probably not part of the
change. Maybe some merging/rebasing went
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29572548
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -129,6 +130,41 @@ class TaskManager(val connectionInfo:
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29572528
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -129,6 +130,41 @@ class TaskManager(val connectionInfo:
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29572469
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -129,6 +130,41 @@ class TaskManager(val connectionInfo:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-96631425
Thank you. I'm trying to find time to review your changes soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bhatsachin commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-95480100
The suggested changes have been made
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user bhatsachin commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-89987417
The compilation error has been fixed. CPU stats are loading properly for
Java 7 and above. For Java 6, the CPU stats column shows Not Available with a
popup message exp
Github user bhatsachin commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-89848884
Hey Robert,
The required changes have been made and are working fine for Java 7
onwards. Using this method, it is not possible to fetch CPU load in Java 6
si
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-88828965
Please let me know when the PR is ready for review again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-88418659
The memory statistics get pretty big when the chart is enabled as well.
Can you hide the string-based statistics when the graph is activated?
http://i.imgur.com/VE0p3D
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r27551487
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -129,6 +129,10 @@ class TaskManager(val connectionInfo:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-88387132
Thank you for the contribution. I'll have a look at the changes.
The integration test of your change
(https://travis-ci.org/apache/flink/builds/56641563) has fail
GitHub user bhatsachin opened a pull request:
https://github.com/apache/flink/pull/553
[FLINK-1792] TM Monitoring: CPU utilization, hide graphs by default and
show summary only
Added CPU Load %, show/hide button for detailed graph and summary for the
metrics
You can merge this pul
40 matches
Mail list logo
