Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r35240445
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r35240432
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph,
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-123815171
@rainiraj Thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-123802868
Thanks @rainiraj. I think we can merge your changes with some small
adjustments.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r35240453
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r35240436
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph,
Github user rainiraj commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-123741223
Hi Max, all your comment feedback have been incorporated in the new pull
request. Please review them.
Thanks
Niraj
---
If your project is set up for it, you
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-123306327
Hi @rainiraj. We want to rework and unify client code. This PR would be
part of it. Can you update your code soon so it can be merged? Otherwise, it
might get reworked by
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-114040994
Another ping. @mjsax would you like to pick it up? There is a test in
TaskCancelTest#cancelJob, which implements this for a test as a static method.
Would be nice to
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-114044225
Ah, didn't check the JIRA. Thanks for pointing this out. @rainiraj, can you
look at the test I've mentioned and remove the code there and use your new
feature? :)
---
If
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-114043438
@rainiraj replied, that he is still on it (see
https://issues.apache.org/jira/browse/FLINK-1818)
---
If your project is set up for it, you can reply to this email and
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-111755816
Any news on this PR? I thinks it is a nice feature? @rainiraj do you still
work on this?
---
If your project is set up for it, you can reply to this email and have your
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r29447805
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -420,6 +428,60 @@ public JobSubmissionResult run(JobGraph jobGraph,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r29447781
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -420,6 +428,60 @@ public JobSubmissionResult run(JobGraph jobGraph,
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-97882155
Thank you for your pull request @rainiraj. I have made some comments. If
you addressed these we would be happy to merge your changes. Feel free to ask
if anything is unclear.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r29462715
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -420,6 +428,60 @@ public JobSubmissionResult run(JobGraph jobGraph,
16 matches
Mail list logo
