Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/672
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-105530009
Ok, I'm running the last Travis tests and then I'm merging :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-105507840
I've rebased and cleaned up the commits. So this should be ready now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-105504716
Do we want to have this in now? I can cherry pick it on top of the latest
master and merge it.
---
If your project is set up for it, you can reply to this email and hav
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-105279617
Should work. Yes `print()` was merged independently. I'll look at it and
clean up the commits tomorrow. I too would like to see it being merged ;)
---
If your project is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-105276798
Whats the status of this pull request?
It seems that the changes to `print()` have been merged independently. I
would like to merge this soon (depending on the status
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-103848414
Hey Fabian. The problem with putting it in the `flink-client` is that the
shell only works with Scala-2.10 and is not included for the Scala-2.11 build.
As far as I've
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-103803452
I am wondering whether it would be better to put this into `flink-client`
instead of `flink-staging`.
Its not a huge component, should be easy to maintain, and would b
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-103638341
Fixed according to comments and linux terminal issue, should now pass all
tests.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-102086481
thanks for the comments Robert, I'll fix the stuff tomorrow!
Indeed, the Scala shell itself is not so much code, most of the changes are
caused by the change of ```pri
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-102082153
The change looks good, I had some easy to resolve comments.
Sadly, it seems that most of the changes are caused by the semantics change
of `print()` ... the scalashel
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30331698
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Ap
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30331377
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkILoop.scala
---
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Ap
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30330524
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/RemoteEnvironment.java ---
@@ -85,4 +87,14 @@ public String toString() {
return "
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30331151
--- Diff:
flink-staging/flink-scala-shell/src/main/java/org.apache.flink/api/java/ScalaShellRemoteEnvironment.java
---
@@ -0,0 +1,84 @@
+
+package or
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30331192
--- Diff:
flink-staging/flink-scala-shell/src/main/java/org.apache.flink/api/java/ScalaShellRemoteEnvironment.java
---
@@ -0,0 +1,84 @@
+
+package or
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30331086
--- Diff:
flink-staging/flink-scala-shell/src/main/java/org.apache.flink/api/java/ScalaShellRemoteEnvironment.java
---
@@ -0,0 +1,84 @@
+
--- End dif
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30330912
--- Diff: flink-staging/flink-scala-shell/pom.xml ---
@@ -0,0 +1,246 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30330874
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala ---
@@ -1327,8 +1327,8 @@ class DataSet[T: ClassTag](set: JavaDataSet[T]) {
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30330756
--- Diff: flink-optimizer/pom.xml ---
@@ -58,6 +58,12 @@ under the License.
guava
${guava.version}
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30330465
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1337,11 +1336,16 @@ public long count() throws Exception {
/**
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30330285
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1337,11 +1336,16 @@ public long count() throws Exception {
/**
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30330062
--- Diff: docs/scala_shell_quickstart.md ---
@@ -0,0 +1,72 @@
+---
+title: "Quickstart: Scala Shell"
+---
+
+
+* This will be replaced
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30329898
--- Diff: docs/scala_shell_quickstart.md ---
@@ -0,0 +1,72 @@
+---
+title: "Quickstart: Scala Shell"
+---
+
+
+* This will be replaced
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/672#discussion_r30329764
--- Diff: docs/scala_shell_quickstart.md ---
@@ -0,0 +1,72 @@
+---
+title: "Quickstart: Scala Shell"
+---
+
+
+* This will be replaced
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-102069667
Amazing! I'm super excited to see this finally implemented.
I'll soon review the changes.
---
If your project is set up for it, you can reply to this email and
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/672
[FLINK-1907] Scala shell
implementation of Scala Shell, for Scala versions 2.10 and 2.11.
Also includes change to "eager" print()
You can merge this pull request into a Git repository by running:
27 matches
Mail list logo
