Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-116266267
No problem ;)
In this case I would kindly ask @andralungu to close the issue manually.
---
If your project is set up for it, you can reply to this email and have
Github user andralungu closed the pull request at:
https://github.com/apache/flink/pull/832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r33419462
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/util/DataSetUtilsITCase.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-116208070
Hi, I added some minor comments about coding style in Scala test case. The
rest things is okay.
I think we can merge this after fixing the style.
---
If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r33419461
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/util/DataSetUtilsITCase.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r33419459
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/util/DataSetUtilsITCase.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-116252016
Looks good :) merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-116252346
Oops! I forgot add This closes #832 into commit message. I mistook
because this is my first commit to upload Apache repository. Sorry. How can I
fix it?
---
If your
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-115134406
Hey Theo,
Thanks a lot for finding my bug there ^^
PR updated to address the Java issues and to contain a pimped Scala
version of `zipWithIndex` :)
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-114883882
Uhmmm... flink.api.scala is imported. That's not the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-114864032
Sorry for my late reply. Has everything worked out by now?
On Tue, Jun 23, 2015 at 2:43 PM, Andra Lungu notificati...@github.com
wrote:
Hey
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-114878728
Actually, I get a weird compile error: it says missing Type parameter for
the map in DataSet.scala...
I think this is because the map is overriden... and I haven't
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-114880352
Is it a type inference problem? Have you tried importing
org.apache.flink.api.scala._ to see if that fixes it?
---
If your project is set up for it, you can reply to
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-114895752
Seems like the problem was that the wrap was returning a
DataSet[(java.lang.Long, T)]
If you change the map to `.map { t = (t.f0.toLong, t.f1) }` it should
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-114481973
Hey @tillrohrmann ,
Sorry for the incredibly late reply. The last weeks have been very hectic.
Nevertheless, I'd like to properly finish and polish this
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32404396
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32410253
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-112000953
Good work @andralungu.
The data set utils are not working with the Scala API. Would be nice to
support for Scala a syntax like
```
val ds:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32405496
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/util/DataSetUtilsITCase.java ---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32404719
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32404633
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32405317
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32415043
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user alexeygrigorev commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32423042
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32430399
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r32439968
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/832
[FLINK-2152] Added zipWithIndex
This PR adds the zipWithIndex utility method to Flink's DataSetUtils as
described in the mailing list discussion:
27 matches
Mail list logo
