[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-17 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-112940323 Perfect, thanks @andralungu! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-16 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-112373119 PR updated to test the same issue in ApplyCoGroupFunctionOnAllEdges and ApplyCoGroupFunction. Also added tests. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-15 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111993642 @andralungu, I believe the same issue appears in `ApplyCoGroupFunctionOnAllEdges` and `ApplyCoGroupFunction`. Could you check if that's the case and fix those too if

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-13 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111761198 Yup, exactly! The use case was: I modified something in the edge data set, called groupReduceOnNeighbors on the result and got NPE, exception that could have been

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-13 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111760267 Hey @andralungu, I'm not sure I understand this one. It's a coGroup of vertices with the edges. For the vertex iterator to be empty, doesn't it mean that there's

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-09 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-110481761 uhmm, guys! IMO this should be merged before the release! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-06 Thread andralungu
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/799 [FLINK-2178][gelly] Fixed groupReduceOnNeighbors bug This PR adds an iterator.hasNext() check in the groupReduceOnNeighbors method, fixing the NoSuchElementException bug reported in FLINK-2178.