Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/935#issuecomment-125890350
Other than the one comment, this looks good.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/935#discussion_r35741171
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/EnumValueSerializer.scala
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/935#issuecomment-125936680
Merged, thanks for your work. :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/935
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/935#discussion_r35631275
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/ScalaSpecialTypesSerializerTest.scala
---
@@ -93,8 +98,11 @@ class
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/935#issuecomment-125536383
Looks good, any objections to me merging this? I can fix the one comment I
had about using serializer.getLength when I merge it.
---
If your project is set up for it,
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/935
[FLINK-2231] Create a Serializer for Scala Enumerations.
This closes FLINK-2231.
The code should work for all objects which follow [the Enumeration idiom
outlined in the
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/935#issuecomment-124582468
PS. The third commit fixes a compilation error in IntelliJ when the
'scala_2.11' profile is active.
---
If your project is set up for it, you can reply to this
