[GitHub] flink pull request: [FLINK-2279] [streaming] Add Connected Iterati...

2015-06-26 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/870#issuecomment-115808761 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-2279] [streaming] Add Connected Iterati...

2015-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/870 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-2279] [streaming] Add Connected Iterati...

2015-06-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/870#issuecomment-115762324 Ah ok, I was just confused since in the new test for it the same stream is used as feedback and result. :sweat_smile: --- If your project is set up for it, you can rep

[GitHub] flink pull request: [FLINK-2279] [streaming] Add Connected Iterati...

2015-06-26 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/870#issuecomment-115756972 There is nothing tricky there: In java every record in the stream passed to closewith() will be fed back. (And closeWith returns this stream). In scala it

[GitHub] flink pull request: [FLINK-2279] [streaming] Add Connected Iterati...

2015-06-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/870#issuecomment-115750835 This looks reasonable. How does the user not specify which elements are feedback and which go to the downstream operator? --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2279] [streaming] Add Connected Iterati...

2015-06-26 Thread senorcarbone
Github user senorcarbone commented on the pull request: https://github.com/apache/flink/pull/870#issuecomment-115724842 no more wrapper types :+1: I approve --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] flink pull request: [FLINK-2279] [streaming] Add Connected Iterati...

2015-06-26 Thread gyfora
GitHub user gyfora opened a pull request: https://github.com/apache/flink/pull/870 [FLINK-2279] [streaming] Add Connected Iteration This PR introduces a new feature that allows the users to treat the iteration head in a streaming iteration as a ConnectedDataStream of the original a