Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r38076538
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0 +1,332
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r38076582
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0 +1,332
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-135360612
Thank you @HuangWHWHW. I merged your pull request with a few minor changes
(see new comments).
---
If your project is set up for it, you can reply to this email and have
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37961564
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37965403
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0 +1,333
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37964105
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37959743
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0 +1,330
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37962927
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0 +1,336
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37974911
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37974619
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-135062701
Thanks @HuangWHWHW. I'll merge your changes when Travis has completed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-135261867
@mxm
Hi,
the CI is pass.
Did it probability failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-134635720
@HuangWHWHW Can you access the CI reports now? Has the Travis team fixed
the problem?
---
If your project is set up for it, you can reply to this email and have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37845122
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0 +1,267
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37845214
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0 +1,234
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37847490
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-134565956
Thanks for the updates! Looks good and I think we can merge your changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37835967
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-134566835
@mxm
Thank you.
Sorry for that I haven`t updated the code in this branch for a long time.
So you can wait the CI to pass.
---
If your project is set up
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-134781611
@StephanEwen
Hi,
Not yet.
I will ask the travis support again.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37762004
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0 +1,234
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-130999180
Hi, I have done a new changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37053652
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r36990804
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0 +1,234
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r37046489
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-130295740
Your pull request doesn't compile:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/74504427/log.txt
---
If your project is set up for it, you can reply to this email
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-127982547
@fhueske
Thank you!I`ll fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r36284181
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/991#discussion_r36284223
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
---
@@ -0,0
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/991#issuecomment-127834382
I still cannot see the CI.
Does any one can help to support this CI info??
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user HuangWHWHW opened a pull request:
https://github.com/apache/flink/pull/991
[FLINK-2480][test]Add tests for PrintSinkFunction
Test PrintSinkFunction:
set number of subtasks with 0 in runtime ctx to make prefix null.
1.set STD.OUT and test print system.out
32 matches
Mail list logo
