[GitHub] flink pull request: [FLINK-2545] add bucket member count verificat...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1067 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2545] add bucket member count verificat...

2015-09-01 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1067#issuecomment-136667661 Looks good, I'll merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2545] add bucket member count verificat...

2015-08-30 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1067#issuecomment-136243437 Nice job, @greghogan , you just pointed out the root cause and the solution. I add the logic to skip latest buckets as @StephanEwen suggested, and add related unit

[GitHub] flink pull request: [FLINK-2545] add bucket member count verificat...

2015-08-29 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1067#issuecomment-135983916 Ah, that makes perfect sense. The last memory segment is not fully used (only until the hash index has initialized enough buckets). The bloom filter initialization

[GitHub] flink pull request: [FLINK-2545] add bucket member count verificat...

2015-08-28 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1067#issuecomment-135885866 I am currently running release-0.10.0-milestone-1. Debugging with Eclipse and looking at MutableHashTable.initTable, numBuckets is computed as 16086. There

[GitHub] flink pull request: [FLINK-2545] add bucket member count verificat...

2015-08-27 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1067#issuecomment-135612599 Thanks for the remind, @zentol and @StephanEwen , I should be too hurry to open this PR. I tried to fix the exception in bloom filter in this PR and verify other

[GitHub] flink pull request: [FLINK-2545] add bucket member count verificat...

2015-08-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1067#issuecomment-135354418 @ChengXiangLi Do you know what caused the problem initially? I was puzzled, because the count in the bucket should never be negative, and a zero sized bucket should