[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1076 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-08-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1076#issuecomment-136339437 Make sure it does not break with @tillrohrmann's recent merge ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-08-31 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1076#issuecomment-136336944 I'll merge this now into `master` and `0.10.0-milestone1`. In the long run, we can hopefully convince curator to offer a shaded version in addition to the

[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-08-30 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1076#issuecomment-136131254 Nice work :) This needs to go into the milestone branch as well. What do you mean with We can easily integrate curator's netty into the jar file.? --- If your