Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/1147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-142667187
Manually merged in b8f58fab56c727b8d44d2a90bbb389ab7544989e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-14517
Ok, if this is out of the way I would suggest to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-141986160
If the operators don't react to watermarks and don't forward watermarks
that means that any downstream operators cannot rely on watermarks.
---
If your project is
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-141973240
I don't think the unit tests are correct. I was playing around with the
tests while adding the integration of the timer service into the StreamTask. I
noticed that
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-142098492
Concerning Watermarks: I think that is the assumption right now, yes.
Since the operators produce records with timestamps based on their
processing time,
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-142098571
Thanks for the pointer with the tests, will have a look and fix this...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-142107041
Actually, I think the tests are okay. The triggers are part of some tests
only, because this is a unit test that checks many features independently.
-
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-141755957
This is a pretty massive addition, but I am excited :)
I will try to look through it today and tomorrow!
---
If your project is set up for it, you can reply to this
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-141817879
wow! I also want to look into this in more detail, it looks promising.
@StephanEwen if you find a bit of time, can you write some more details to
guide the
10 matches
Mail list logo
