Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1449
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1449#issuecomment-163893598
Thanks for the reviews Robert and Sachin!
I've addressed Robert's comment. If there are no objections, I would like
to merge this.
---
If your project is set up
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1449#issuecomment-163953942
I think its good to merge, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1449#discussion_r47281222
--- Diff:
flink-runtime-web/web-dashboard/app/scripts/modules/overview/overview.svc.coffee
---
@@ -24,7 +24,7 @@ angular.module('flinkApp')
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1449#discussion_r47291227
--- Diff:
flink-runtime-web/web-dashboard/app/scripts/modules/overview/overview.svc.coffee
---
@@ -24,7 +24,7 @@ angular.module('flinkApp')
@loadOverview
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1449#issuecomment-163866658
Tested it out locally. Works well with `gulp watch` and custom web frontend
port.
A few things I noticed:
1. Job Manager's log and stdout are not
