Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1205#issuecomment-146158372
Thanks for the fast update! Good to merge.
I added a comment about the parameter order that could be addressed if you
agree.
---
If your project is set up for it,
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41377804
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -126,6 +126,131 @@ object Graph {
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1205#issuecomment-146225895
Great, thanks! I will re-order the parameters and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1205#issuecomment-145970361
I'm worrying about the name of method `fromCsvReader`. It seems that the
method should receive `CsvReader` object and read graph data from the reader
object. Why we
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1205#issuecomment-145979805
Hey @chiwanpark,
this is how the Java method works, i.e. creates a `CsvReader ` object and
returns the graph when calling the appropriate types methods. I only kept
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1205#issuecomment-146030951
Okay, I understand it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41284498
--- Diff: docs/libs/gelly_guide.md ---
@@ -194,6 +194,27 @@ val edgeTuples = env.readCsvFile[String, String,
Double]("path/to/edge/input")
val
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41284938
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -126,6 +126,122 @@ object Graph {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41287065
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -126,6 +126,122 @@ object Graph {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41284820
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -126,6 +126,122 @@ object Graph {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41287202
--- Diff: docs/libs/gelly_guide.md ---
@@ -194,6 +194,27 @@ val edgeTuples = env.readCsvFile[String, String,
Double]("path/to/edge/input")
val
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1205#issuecomment-145939652
Thanks so much for the review @fhueske!
I agree with your comments. I will rename the parameter to `readVertices`,
make it mandatory, and better explain it on the
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1205
[FLINK-2785] [gelly] implements fromCsvReader for gelly-scala
This is the last method missing from the Scala Graph implementation.
In order to be as close as possible to the Java implementation, I
14 matches
Mail list logo
