Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1218#issuecomment-145890525
Thanks all for the reviews. Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1218#issuecomment-145873239
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1218#issuecomment-145740343
Updated based on review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1218#issuecomment-145486238
If you are cleaning up anyways, how about renaming the `RegularTask` to
`BatchTask`? That is what it is, after all, the core task class for batch
operations. There
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1218#issuecomment-145537573
Makes sense, will make that update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1218#discussion_r41101900
--- Diff: flink-tests/src/test/resources/logback-test.xml ---
@@ -27,7 +27,7 @@
-
+
--- End diff --
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1218#discussion_r41101714
--- Diff:
flink-staging/flink-tez/src/main/java/org/apache/flink/tez/runtime/TezTask.java
---
@@ -402,7 +402,7 @@ private void initInputLocalStrategy(int
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1218#issuecomment-145383808
Looks good to merge except minor issues for me. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1218#issuecomment-145381091
Since this change involve renaming classes I will merge this end of day
tomorrow if no more comments.
---
If your project is set up for it, you can reply to this
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1218#discussion_r41101621
--- Diff: flink-tests/src/test/resources/logback-test.xml ---
@@ -27,7 +27,7 @@
-
+
--- End diff --
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1218#issuecomment-145384630
Hi @chiwanpark , thanks for the review. Thanks for catching the typo and
miss parentheses.
Just push the update.
---
If your project is set up for it, you can
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/1218
[FLINK-2815] [REFACTOR] Remove Pact from class and file names since it is
no longer valid reference
Remove Pact word from class and file names in Apache Flink.
Pact was the name used in
13 matches
Mail list logo
