[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1361#discussion_r45052205 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/ConnectionUtils.java --- @@ -180,7 +180,41 @@ public static InetAddress

[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1361#discussion_r45052228 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/ConnectionUtils.java --- @@ -180,7 +180,41 @@ public static InetAddress

[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-17 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1361#issuecomment-157378877 Will merge and address the comments... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-17 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1361#issuecomment-157347414 Trying this out... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-17 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1361#issuecomment-157316807 +1 Like previously discussed this seems to be a good strategy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-17 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/1361 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1361#issuecomment-157503990 This has been merged, @StephanEwen probably forgot to close the PR, so I'm closing it manually. --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-2967] Enhance TaskManager network detec...

2015-11-16 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1361 [FLINK-2967] Enhance TaskManager network detection JIRA: https://issues.apache.org/jira/browse/FLINK-2967 - Increase timeout for `LOCAL_HOST` address detection strategy - give the