Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1428
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-179926670
I went through all the classes in the relevant modules outside `flink-core`
with @fhueske and annotated them properly.
I've rebased the changes and checked with the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-173511286
Cool, thank you.
I'll rebase the PR, and go over the APIs again as well
---
If your project is set up for it, you can reply to this email and have your
reply
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-170333018
Thanks for the update!
I'd like to do another pass over the DataSet Java and Scala classes next
week.
---
If your project is set up for it, you can reply to this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-169335005
Thanks a lot for looking into this!
In the `ExecutionConfig` I've made the following methods experimental:
- setAutoWatermarkInterval
- enableTimestamps
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-165848516
Do we want to make the IOFormats Public as well?
Most of them are hidden by helper methods of the `ExecutionEnvironment`.
However, they can also be used as regular
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-165171199
Hi,
I had a look and have some comments as well
- `ExecutionConfig`: Do we want to make the whole class public? Are we sure
that we do not change the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-164762014
Thank you all for the comments.
I'll rename the interfaces to `@Public` and `@Experimental`.
I'll keep the annotation on the `ConfigConstants` class to
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-164764484
I didn't make `MemorySegment` a public API. Lets declare it in the pull
request as stable.
I decided to mark `XORShiftRandom` and `NumberSequenceIterator` as stable
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-164768159
> Are inner classes of a class tagged as PublicInterface also marked as
public/stable?
Yes!
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-164777618
I addressed all issues you've mentioned and rebased the code to the current
master. I would like to merge this soon!
---
If your project is set up for it, you can
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-164781638
Thank you for your patch. I've added it to the PR.
Regarding your question: I would keep name changes separate from this PR.
Once this one is merged, we can
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-164665117
Since this is primarily used to tag Interface or methods, could we just
call the annotations as Public and Experimental rather than PublicInterface and
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-164288665
Thanks for the initiative, Robert. I had a look and here are some thoughts:
### General Comments
- The interface declarations should declare
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1427#discussion_r46833253
--- Diff:
flink-annotations/src/main/java/org/apache/flink/annotation/PublicExperimental.java
---
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-162559507
Are inner classes of a class tagged as `PublicInterface` also marked as
public/stable?
---
If your project is set up for it, you can reply to this email and have
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-162557821
Should we also change names of stuff or open separate Jiras, PRs. I'm
asking, for example, because of `CheckpointNotifier` which should be called
`CheckpointListener`
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-162578546
I created a patch of changes in the Stream API that I would propose:
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1427#discussion_r46756747
--- Diff: flink-core/src/main/java/org/apache/flink/types/Pair.java ---
@@ -33,6 +34,7 @@
* @param Type of the pair's first element.
* @param
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1426#issuecomment-161045370
Hi @rmetzger, thanks for taking the initiative for this issue!
I tried to review the PR, but the diff set it too large for the Github
viewer. I know, I could
Github user rmetzger closed the pull request at:
https://github.com/apache/flink/pull/1426
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1427#discussion_r46323631
--- Diff: flink-core/src/main/java/org/apache/flink/types/Pair.java ---
@@ -33,6 +34,7 @@
* @param Type of the pair's first element.
* @param
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1427
[FLINK-3093] Introduce annotations for interface stability in flink-core
Please see https://github.com/apache/flink/pull/1426
You can merge this pull request into a Git repository by running:
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1428
[FLINK-3093] Introduce annotations for interface stability in remaining
modules
Please see https://github.com/apache/flink/pull/1426
This pull request depends on
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1426#issuecomment-161056518
Okay, I'll reopen two new PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1426
[FLINK-3093] Introduce annotations for interface stability
With this pull request, I'm introducing annotations for marking the
stability of certain Flink interfaces.
The annotations are
26 matches
Mail list logo
