[GitHub] flink pull request: [FLINK-3131] Expose checkpoint metrics

2015-12-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3131] Expose checkpoint metrics

2015-12-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1453#issuecomment-167408343 Very good pull request! Will merge this, address the code style comment from @mxm. --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-3131] Expose checkpoint metrics

2015-12-17 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1453#discussion_r47895579 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateForTask.java --- @@ -48,18 +48,38 @@ /** The state of the parallel

[GitHub] flink pull request: [FLINK-3131] Expose checkpoint metrics

2015-12-17 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1453#issuecomment-165430143 Thanks @uce for this nice pull request. Looks very good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-3131] Expose checkpoint metrics

2015-12-17 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1453#discussion_r47895592 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateHandle.java --- @@ -43,4 +43,15 @@ * used any more. */ void

[GitHub] flink pull request: [FLINK-3131] Expose checkpoint metrics

2015-12-14 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/1453 [FLINK-3131] Expose checkpoint metrics - Adds `long getStateSize()` to `StateHandle` and `KvStateSnapshot`. Everything except test classes and `LazyDbKvState` implement this. `LazyDbKvState` could