[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...

2015-12-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1442#issuecomment-164828376 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...

2015-12-15 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1442#issuecomment-164883472 I will cherry-pick the commit over to the 0.10 branch. Thanks @ndimiduk! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...

2015-12-15 Thread ndimiduk
Github user ndimiduk commented on the pull request: https://github.com/apache/flink/pull/1442#issuecomment-164882643 Should I post a second PR for merging to 0.10-SNAPSHOT, or will you handle cherry-pick to active release branches? Thanks a lot @fhueske ! --- If your project is set

[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...

2015-12-15 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1442#issuecomment-164880422 Thanks for the PR! I'll merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...

2015-12-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...

2015-12-08 Thread ndimiduk
GitHub user ndimiduk opened a pull request: https://github.com/apache/flink/pull/1442 [FLINK-3147] HadoopOutputFormatBase should expose mutexes for subclasses Simple patch. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...

2015-12-08 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1442#issuecomment-162991974 Thanks for the patch! Can you apply the same changes to `org.apache.flink.api.java.hadoop.mapred.HadoopOutputFormatBase`, the base class for `mapred` API

[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...

2015-12-08 Thread ndimiduk
Github user ndimiduk commented on the pull request: https://github.com/apache/flink/pull/1442#issuecomment-163010606 Sure thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...

2015-12-08 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1442#issuecomment-163074809 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature