[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-25 Thread spdrnl
Github user spdrnl commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r54090368 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/** + *

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-12 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/1620 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52575628 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/** + *

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52623142 --- Diff: flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52623666 --- Diff: flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java ---

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52623648 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52625876 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52625891 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/** + *

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52621606 --- Diff: flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52622167 --- Diff: flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52623063 --- Diff: flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52624579 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52625364 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52622956 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52623292 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52625293 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52630950 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/** + *

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52626959 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52631298 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52626379 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52627131 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52630685 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/**

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1620#issuecomment-182959361 Good work @zentol. I had some inline comments. My main concern is that upon recovery you'll write all elements of the previously written checkpoint again

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-11 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1620#discussion_r52634496 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericExactlyOnceSink.java --- @@ -0,0 +1,173 @@ +/** + *

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-10 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/1620 [FLINK-3332] Cassandra connector This PR adds an Exactly-Once Cassandra Sink. The Exactly-once guarantee is made by saving incoming records in the OperatorState, and only committing them