Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-189004909
Pushed. Thanks for the explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-188985984
If you can quickly do it, yes.
Otherwise whoever merges this tomorrow, please remove the sysout statements.
We try to keep the maven output a bit cleaner
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-188982973
@StephanEwen just to clarify, since time is of the essence, would you like
me to update the pull request without the println's?
---
If your project is set up for it,
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-188929386
This looks good to me.
+1 for merging, but removing the System.out.println
---
If your project is set up for it, you can reply to this email and have your
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183287868
So, if I understand correctly, this is aiming to fix the problem that was
brought up by [1], but in a different way then proposed there.
I still have the same
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183348625
Hi, @ggevay, these fixes to the reduce drivers are independent of changes
to `MutableObjectIterator`. This patch is intended to fix the bug you reported
in
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183375884
Sorry, but I don't think it is independent, because the bug in the reduce
drivers could alternatively be fixed by saying that the bug is actually not in
the reduce
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183389185
`MergeIterator.next(reuse)` should allow object swapping. The source code
documentation should be improved to make this clearer, but this contract is
necessary to
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183390101
OK, after Stephan's comment on FLINK-3291, I agree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1626
[FLINK-3340] [runtime] Fix object juggling in drivers
A second attempt at object swapping in reduce drivers.
You can merge this pull request into a Git repository by running:
$ git pull
10 matches
Mail list logo
